b146

A parent item that was copied and pasted without its children would incorrectly still have cost/weight values that reflected those with the children that it no longer had. That has been fixed.

While fixing the issue above, I noticed that Recalculate All was not actually recalculating everything. I fixed that issue. This adds a slight amount to the total calculation times compared to what it was, but everything should now be getting recalculated correctly. This should have no impact on normal operation as it only applies when doing a Recalc All. (GCA calls for one when loading a character, but not normally otherwise).

Changed copying traits slightly. When you are copying traits with children, GCA will now ask if you want to copy the children also. If you do, great, if you don’t, then only the ones already explicitly selected are copied.

Consolidated some duplicate procedures.

* Attack Modes boxes

You can now hit Enter to launch Edit for the selected item.

The Notes text at the bottom was still sometimes getting cut off, and some weirdness was definitely happening with sizing it, so I replaced those bits with other bits.

* Trait boxes

I’ve made the right-click context menu available to the “No traits to display” label, so that you can Paste from there.

I made an adjustment to the routine that sizes the boxes to hopefully fix an intermittent but long-standing issue where the list box makes itself only a single item high, even though the trait box knows it should be larger than that.

* Sheet View

You should now be able to right-click on a trait’s edit field (when it is highlighted but not actually in active edit mode) to get the pop-up menu for traits.

* Official Character Sheet

Updated with options and support to enable/disable the on-sheet edit features and the buttons that call the trait dialogs.

* Data Files

Corrected some text in a couple _New Disadvantage traits, and removed one that was in an Advantages list.